Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to ignore sides on autocrop #924

Merged
merged 2 commits into from
Aug 8, 2020

Conversation

cbanfiel
Copy link
Contributor

@cbanfiel cbanfiel commented Aug 7, 2020

What's Changing and Why

Added the ability for users to ignore certain sides while autocropping, I needed to have this feature for a work project so I figured it might be useful for others as well.

What else might be affected

Nothing, just allowing the autocrop function to take in an ignoreSides object for more specific crops.

Example

image.autocrop({ cropOnlyFrames: false, ignoreSides:{north: true, west:true}})
(will ignore cropping north and west sides)

Tasks

  • Add tests
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label
📦 Published PR as canary version: 0.15.1-canary.924.1021.0

✨ Test out this PR locally via:

npm install @jimp/cli@0.15.1-canary.924.1021.0
npm install @jimp/core@0.15.1-canary.924.1021.0
npm install @jimp/custom@0.15.1-canary.924.1021.0
npm install jimp@0.15.1-canary.924.1021.0
npm install @jimp/plugin-blit@0.15.1-canary.924.1021.0
npm install @jimp/plugin-blur@0.15.1-canary.924.1021.0
npm install @jimp/plugin-circle@0.15.1-canary.924.1021.0
npm install @jimp/plugin-color@0.15.1-canary.924.1021.0
npm install @jimp/plugin-contain@0.15.1-canary.924.1021.0
npm install @jimp/plugin-cover@0.15.1-canary.924.1021.0
npm install @jimp/plugin-crop@0.15.1-canary.924.1021.0
npm install @jimp/plugin-displace@0.15.1-canary.924.1021.0
npm install @jimp/plugin-dither@0.15.1-canary.924.1021.0
npm install @jimp/plugin-fisheye@0.15.1-canary.924.1021.0
npm install @jimp/plugin-flip@0.15.1-canary.924.1021.0
npm install @jimp/plugin-gaussian@0.15.1-canary.924.1021.0
npm install @jimp/plugin-invert@0.15.1-canary.924.1021.0
npm install @jimp/plugin-mask@0.15.1-canary.924.1021.0
npm install @jimp/plugin-normalize@0.15.1-canary.924.1021.0
npm install @jimp/plugin-print@0.15.1-canary.924.1021.0
npm install @jimp/plugin-resize@0.15.1-canary.924.1021.0
npm install @jimp/plugin-rotate@0.15.1-canary.924.1021.0
npm install @jimp/plugin-scale@0.15.1-canary.924.1021.0
npm install @jimp/plugin-shadow@0.15.1-canary.924.1021.0
npm install @jimp/plugin-threshold@0.15.1-canary.924.1021.0
npm install @jimp/plugins@0.15.1-canary.924.1021.0
npm install @jimp/test-utils@0.15.1-canary.924.1021.0
npm install @jimp/bmp@0.15.1-canary.924.1021.0
npm install @jimp/gif@0.15.1-canary.924.1021.0
npm install @jimp/jpeg@0.15.1-canary.924.1021.0
npm install @jimp/png@0.15.1-canary.924.1021.0
npm install @jimp/tiff@0.15.1-canary.924.1021.0
npm install @jimp/types@0.15.1-canary.924.1021.0
npm install @jimp/utils@0.15.1-canary.924.1021.0
# or 
yarn add @jimp/cli@0.15.1-canary.924.1021.0
yarn add @jimp/core@0.15.1-canary.924.1021.0
yarn add @jimp/custom@0.15.1-canary.924.1021.0
yarn add jimp@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-blit@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-blur@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-circle@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-color@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-contain@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-cover@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-crop@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-displace@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-dither@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-fisheye@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-flip@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-gaussian@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-invert@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-mask@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-normalize@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-print@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-resize@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-rotate@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-scale@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-shadow@0.15.1-canary.924.1021.0
yarn add @jimp/plugin-threshold@0.15.1-canary.924.1021.0
yarn add @jimp/plugins@0.15.1-canary.924.1021.0
yarn add @jimp/test-utils@0.15.1-canary.924.1021.0
yarn add @jimp/bmp@0.15.1-canary.924.1021.0
yarn add @jimp/gif@0.15.1-canary.924.1021.0
yarn add @jimp/jpeg@0.15.1-canary.924.1021.0
yarn add @jimp/png@0.15.1-canary.924.1021.0
yarn add @jimp/tiff@0.15.1-canary.924.1021.0
yarn add @jimp/types@0.15.1-canary.924.1021.0
yarn add @jimp/utils@0.15.1-canary.924.1021.0

@hipstersmoothie
Copy link
Collaborator

@cbanfiel can you fix the lint errors? also please try to add a test. thank you!

@cbanfiel
Copy link
Contributor Author

cbanfiel commented Aug 7, 2020

Added tests and fixed lint issues. Thanks

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Aug 8, 2020
@hipstersmoothie hipstersmoothie merged commit e67d683 into jimp-dev:master Aug 8, 2020
@hipstersmoothie
Copy link
Collaborator

🚀 PR was released in v0.16.0 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants