Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PNG Options #604

Merged
merged 2 commits into from
Sep 9, 2018
Merged

Fix PNG Options #604

merged 2 commits into from
Sep 9, 2018

Conversation

hipstersmoothie
Copy link
Collaborator

What's Changing and Why

PNG options weren't being passed to write method in correct way so they did nothing, now they work again.

Also added colorType method so a user can set 0 (greyscale) if they want to

What else might be affected

Tasks

  • Add tests
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label

@hipstersmoothie hipstersmoothie added the bug there is a bug in the way jimp behaves label Sep 8, 2018
@edi9999 edi9999 merged commit 8cd6eb0 into jimp-dev:master Sep 9, 2018
@hipstersmoothie hipstersmoothie deleted the png-options branch September 11, 2018 02:56
@hipstersmoothie hipstersmoothie changed the title Png options Fix PNG Options Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug there is a bug in the way jimp behaves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants