Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Range doesn't handle big data properly #4523

Open
azmy60 opened this issue Jun 19, 2024 · 1 comment
Open

Select Range doesn't handle big data properly #4523

azmy60 opened this issue Jun 19, 2024 · 1 comment
Labels
Possible Bug A possible bug that needs investigation

Comments

@azmy60
Copy link
Contributor

azmy60 commented Jun 19, 2024

Right now, if I have a 8mb of dataset (5000 rows) on tabulator with Select Range enabled, it becomes very slow. Selecting a cell by clicking it takes about 5-10 seconds until it actually shows the selection outlines and the UI hangs within those seconds.

It looks like Select Range is looping through all data instead of the data that are necessary to check. It should work like virtual renderer.

I used the same dataset on google sheet and it works perfectly and doesn't lag at all except when I paste the data right onto it which takes around > 10 seconds.

@azmy60 azmy60 added the Possible Bug A possible bug that needs investigation label Jun 19, 2024
@olifolkerd
Copy link
Owner

@azmy60 as the man who built the select range module, are you not best placed to submit a PR for this one?

Cheers

Oli :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Possible Bug A possible bug that needs investigation
Projects
None yet
Development

No branches or pull requests

2 participants