Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell "edited" flag is lost on row.reformat() #4509

Open
mormitech opened this issue May 27, 2024 · 1 comment
Open

Cell "edited" flag is lost on row.reformat() #4509

mormitech opened this issue May 27, 2024 · 1 comment
Labels
Possible Bug A possible bug that needs investigation

Comments

@mormitech
Copy link

Describe the bug
When calling .reformat() on a row containing some edited cells - expecting it will only repaint the row and reformat its values - it unfortunately kills the edited flags as well as a sideeffect.

Tabulator Info
6.2.1

Working Example
https://jsfiddle.net/7czu2ksm/

To Reproduce

  1. open jsfiddle link
  2. edit the only editable cell (Mary May)
  3. click "reformat" button above table to trigger a row reformat on row0
  4. check console: value change is persisted but edited flag is lost

Screenshots
image

@mormitech mormitech added the Possible Bug A possible bug that needs investigation label May 27, 2024
@mormitech
Copy link
Author

Well, I think I'm starting to see the problem now once I analyzed the code a bit. Upon row.reformat() all the cells are completely bulldozed down and "recreated", losing everything they had. Modules, initialValue, everything.

image

Some caching-restoring would have been nice before this step, I see what I can do to mitigate on my end. I'm pretty sure this cannot be fixed with a workaround without modifying Tabulator code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Possible Bug A possible bug that needs investigation
Projects
None yet
Development

No branches or pull requests

1 participant