Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Off-canvas menu defaults not set properly #447

Closed
ethanmay opened this issue Sep 3, 2015 · 6 comments
Closed

Off-canvas menu defaults not set properly #447

ethanmay opened this issue Sep 3, 2015 · 6 comments
Labels

Comments

@ethanmay
Copy link

ethanmay commented Sep 3, 2015

When using the WP menu editor to set a menu to the "Mobile" theme location, the off-canvas menu will not display until you go through the following process:

  1. Open Customizer > "Mobile Menu Settings"
  2. Open "Mobile navigaton layout"
  3. Default is set to off-canvas, select topbar then off-canvas in order to re-save the menu
    • Note: if you save and leave the customizer at this point, the front end will display the off-canvas menu but it will be broken.
  4. Go back, open "Mobile navigation position"
  5. Default is set to left, select right then left in order to re-save the menu
  6. Off-canvas menu now displays as expected

Tested in WP 4.3 using FoundationPress 1.2.0.

PS - Love Zurb, love FoundationPress, thanks for this awesome resource. 👍

@olefredrik
Copy link
Owner

Thanks for your bug report and quickfix 👍

@olefredrik olefredrik added the bug label Sep 3, 2015
@olefredrik
Copy link
Owner

Fixed #449

@chriscarpenter12
Copy link

I still had this issue still after the merge. I had to do exactly as @ethanmay described to get the offcanvas to work correctly. I verified I had the changes in #449.

@jochienabuurs
Copy link

Issue still exists indeed. I pulled in the code just a few hours ago so i'm sure i have the newest version.

@adibbz
Copy link

adibbz commented Sep 17, 2015

Still seeing this issue today. Pulled code this past monday. @ethanmay solution fixed it for me.

@olefredrik olefredrik reopened this Sep 18, 2015
@olefredrik
Copy link
Owner

Hi guys. @skoldin has made a bugfix: #471
Please pull the latest version and verify that everything is working as expected.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants