-
Notifications
You must be signed in to change notification settings - Fork 870
Error notice referencing enqueue-scripts.php #1128
Comments
@AmyGail What version of PHP are you running on Mamp. I am guessing it is old. |
I'm on 7.1.1 |
@AmyGail I just tested on 6.4 and 7 and have no error. However, I did test on an older version of PHP and I get the error. @colin-marshall any comment here? i think it has to do with the usage asset_path function and line 18. Maybe we should tweak... |
@JPOak I guess we should have tested that before merging. The solution is to store the result of explode in a variable and then run the end function on that variable. Source: |
@colin-marshall I was looking at that exact stack! |
@AmyGail On line 18 replace that with the below and see if that works.
|
Looks like it works! |
@AmyGail Sorry about that. We added a new asset hashing feature and still working out the kinks. I will do a PR now for that fix. |
No worries! I appreciate the quick fix. |
Hello All.
I just installed the latest version and received the following notice on activation.
"( ! ) Notice: Only variables should be passed by reference in /.../enqueue-scripts.php on line 18".
Here's a screenshot in case it's helpful.
Thanks for all your hard work.
The text was updated successfully, but these errors were encountered: