Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Where did the npm package into the archive? #1090

Closed
MrAndreius opened this issue Sep 24, 2017 · 8 comments
Closed

Where did the npm package into the archive? #1090

MrAndreius opened this issue Sep 24, 2017 · 8 comments

Comments

@MrAndreius
Copy link

gulp.task package not found or .....

@colin-marshall
Copy link
Collaborator

Looks like we forgot to port the task over to the new gulpfile. Thanks for letting us know!

@nitrokevin
Copy link

I think ole said it wasn’t reliable in another post, but I miss it a lot personally :)

@colin-marshall
Copy link
Collaborator

Ahhh yes, it is a duplicate of #1042.

@olefredrik (or anybody else) can you tell me what specifically was not working with the package task?

@MrAndreius
Copy link
Author

I have everything worked perfectly
it was so convenient to pack

@olefredrik
Copy link
Owner

If you got it working, feel free to bring it back in.

@olefredrik
Copy link
Owner

olefredrik commented Oct 12, 2017

@colin-marshall There have been problems with infinite loops causing huge zip-files.

Just wanted to add to this that it's not really the folder, but just the .zip file that needs to be deleted. I made the mistake of creating a package once and then went to lunch and came back with a 400GB+ file, that pretty much crashed my desktop using all available space ;)

#538 (comment)

There have also been issues with npm run package not being compatible with different versions of Node. It always worked for me, but after receiving e-mails, github issues, and forum posts about the package script not working as expected, I decided to just remove it.

That said, I made a mistake just removing the packaging feature without further notice. In the spirit of open source I should have asked the community first. If anyone wants to bring it back in, pull requests are always welcome.

@colin-marshall
Copy link
Collaborator

@olefredrik #538 dealt with grunt so it is unrelated to the gulp package task that was removed. I rewrote it for gulp in 4811705

I'm down to bring it back in, but would like to read up on the node version issues first. I'll see if I can find anything in a search...

@colin-marshall
Copy link
Collaborator

@olefredrik I just searched all issues for the word "package" sorted chronologically from newest to oldest and could not find any issues, resolved or unresolved, relating to problems with the gulp package task. All problems seems to have been with grunt.

I think it's safe for us to add it back in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants