Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

$offcanvas-size is deprecated #1048

Closed
bej-soan opened this issue Aug 23, 2017 · 3 comments
Closed

$offcanvas-size is deprecated #1048

bej-soan opened this issue Aug 23, 2017 · 3 comments

Comments

@bej-soan
Copy link
Contributor

With a fresh install (local) I get the following warnings in the terminal with npm start:

WARNING: $offcanvas-size is deprecated and not used anymore! Please update your settings and use the map $offcanvas-sizes instead
Backtrace:
node_modules/foundation-sites/scss/components/_off-canvas.scss:78, in mixin off-canvas-basics
node_modules/foundation-sites/scss/components/_off-canvas.scss:439, in mixin foundation-off-canvas
src/assets/scss/app.scss:33

WARNING: $offcanvas-vertical-size is deprecated and not used anymore! Please update your settings and use the map $offcanvas-vertical-sizes instead
Backtrace:
node_modules/foundation-sites/scss/components/_off-canvas.scss:82, in mixin off-canvas-basics
node_modules/foundation-sites/scss/components/_off-canvas.scss:439, in mixin foundation-off-canvas
src/assets/scss/app.scss:33

Is this an old definition in foundationpress or do I have to update something in my node_modules?

@olefredrik
Copy link
Owner

Thanks for reporting in. Seems like there has been a breaking change in Foundation 6.4.2 or 6.4.3 that produces this deprecation warning. I have now made a change in package.json that points directly to version 6.4.1. #1049

If you clone a fresh version of the repo and do a npm install and npm start now, you shouldn't get any deprecation warnings.

@navjeetsingh
Copy link

I am using Zeeks Starters theme, Heisenberg with Foundation and I have tried to update foundation, and now i get the following error.

WARNING: $offcanvas-size is deprecated and not used anymore! Please update your settings and use the map $offcanvas-sizes instead
Backtrace:
node_modules/foundation-sites/scss/components/_off-canvas.scss:78, in mixin off-canvas-basics
node_modules/foundation-sites/scss/components/_off-canvas.scss:439, in mixin foundation-off-canvas
assets/sass/vendors/_foundation.scss:29

WARNING: $offcanvas-vertical-size is deprecated and not used anymore! Please update your settings and use the map $offcanvas-vertical-sizes instead
Backtrace:
node_modules/foundation-sites/scss/components/_off-canvas.scss:82, in mixin off-canvas-basics
node_modules/foundation-sites/scss/components/_off-canvas.scss:439, in mixin foundation-off-canvas
assets/sass/vendors/_foundation.scss:29

I have downloaded the latest foundation from github and replaced the only the file which is that folder. Any guidance where i have gone wrong?

Thank you.

@apsolut
Copy link

apsolut commented Sep 22, 2017

Yap. confirming warning: $offcanvas-size is deprecated (clean download from getting-started and run npm etc...) 6.4.1, 6.4.3....

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants