Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate decode event #56

Open
SassNinja opened this issue Mar 22, 2023 · 0 comments
Open

Deprecate decode event #56

SassNinja opened this issue Mar 22, 2023 · 0 comments

Comments

@SassNinja
Copy link

@olefirenko as I can see you've introduced the result event in #43 and kept the decode event to avoid a breaking change

However the README only shows usage of @decode which encourages people to still use it. I'd recommend to remove it entirely and only show the usage of @result. Going one step further could be an actual deprecation warning when using decode so that you might delete it in future.

Another thing I've noticed is you started describing the shape of the result

The result is the object with the following properties:

However this isn't finished since nothing follows the colon. I think it would be helpful to finish this 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant