Invalid Rule Handling #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject and return like it does not exist
Moving invalid const into group rule file since it only applies to group rules.
This probably isn't useful since the refresh phase should fail on the data object, we should be able to test/view by just ttrying to update to a new group which does exist.
|
I could use additional assistance with this one, since the "free" okta accounts do not have the ability to create / use group rules. Mainly someone who can run the acceptance tests and see if they're working and as-desired. |
|
Hi @ymylei! Thanks for the PR! I'll run the acceptance tests using test org. If everything is good, I'll merge the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Designed to deal with #157
A group rule becomes
INVALIDwhen one of the groups in thegroup_assignmentsis deleted (generally via the API) while the rule itself is still using it.A group rule in the
INVALIDstate can only be read or deleted, no other operations appear to be supported.This adds handling to the provider to allow it to recognize this state, and handle it so when it is encountered, it will allow the rule to still be deleted, and additionally uses the customdiff to ensure that