Adds "pattern" property for okta_user_schema and okta_user_base_schema. #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
fitzoh
commented
Jul 29, 2020
okta/user_schema.go
Outdated
| "pattern": &schema.Schema{ | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Description: "The validation pattern to use for the subschema. Must be null, '.+', or '[<pattern>]+'", |
There was a problem hiding this comment.
Suggested change
| Description: "The validation pattern to use for the subschema. Must be null, '.+', or '[<pattern>]+'", | |
| Description: "The validation pattern to use for the subschema. Must be '.+', or '[<pattern>]+' if present.'", |
Think this might be slightly better, still not sure if we would want to clarify what the pattern can look like.
noinarisak
added
needs-investigation
…okta into user-schema-patterns � Conflicts: � okta/user_schema.go � sdk/user_schema_models.go
bogdanprodan-okta
added
enhancement
|
Hi @fitzoh! Thanks for the PR! I took the liberty to push some fixes regarding the |
|
Great, thanks @bogdanprodan-okta ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(At least partially) addresses https://github.com/terraform-providers/terraform-provider-okta/issues/149.
From the API docs it looks like this pattern might only be valid for the
loginproperty.Not sure if that's a restriction that should be enforced here.
Holding off on doc updates until I can get some feedback on how to proceed.