From df44860f2a3e3b0f95ca3a6df68b0fd492235192 Mon Sep 17 00:00:00 2001 From: bogdanprodan-okta Date: Thu, 4 Mar 2021 13:47:20 +0200 Subject: [PATCH 1/2] Fixed error handler --- okta/config.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/okta/config.go b/okta/config.go index 8edb1e719..c56fac6ed 100644 --- a/okta/config.go +++ b/okta/config.go @@ -97,10 +97,10 @@ func (c *Config) loadAndValidate() error { } func errHandler(resp *http.Response, err error, numTries int) (*http.Response, error) { - defer resp.Body.Close() if err != nil { - return nil, err + return resp, err } + defer resp.Body.Close() err = okta.CheckResponseForError(resp) if err != nil { oErr, ok := err.(*okta.Error) From d1b7ee5b23432bf5157135f90430854c1311538d Mon Sep 17 00:00:00 2001 From: bogdanprodan-okta Date: Fri, 5 Mar 2021 08:37:55 +0200 Subject: [PATCH 2/2] Removed validation for 'single_logout_issuer' --- okta/resource_okta_app_saml.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/okta/resource_okta_app_saml.go b/okta/resource_okta_app_saml.go index 3a886a019..2bb21bcf2 100644 --- a/okta/resource_okta_app_saml.go +++ b/okta/resource_okta_app_saml.go @@ -325,11 +325,10 @@ func resourceAppSaml() *schema.Resource { }, }, "single_logout_issuer": { - Type: schema.TypeString, - Optional: true, - Description: "The issuer of the Service Provider that generates the Single Logout request", - ValidateDiagFunc: stringIsURL(validURLSchemes...), - RequiredWith: []string{"single_logout_url", "single_logout_certificate"}, + Type: schema.TypeString, + Optional: true, + Description: "The issuer of the Service Provider that generates the Single Logout request", + RequiredWith: []string{"single_logout_url", "single_logout_certificate"}, }, "single_logout_url": { Type: schema.TypeString,