diff --git a/okta/data_source_okta_default_policy.go b/okta/data_source_okta_default_policy.go index 985a08f8f..1ce1676a4 100644 --- a/okta/data_source_okta_default_policy.go +++ b/okta/data_source_okta_default_policy.go @@ -32,5 +32,9 @@ func dataSourceDefaultPolicies() *schema.Resource { } func dataSourceDefaultPolicyRead(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics { + policyType := d.Get("type").(string) + if policyType == sdk.IdpDiscoveryType { + return setPolicyByName(ctx, d, m, "Idp Discovery Policy") + } return setPolicyByName(ctx, d, m, "Default Policy") } diff --git a/okta/data_source_okta_default_policy_test.go b/okta/data_source_okta_default_policy_test.go index 8915c0584..371f9c797 100644 --- a/okta/data_source_okta_default_policy_test.go +++ b/okta/data_source_okta_default_policy_test.go @@ -10,9 +10,9 @@ import ( "github.com/oktadeveloper/terraform-provider-okta/sdk" ) -func TestAccOktaDataSourceDefaultPolicy_read(t *testing.T) { +func TestAccOktaDataSourceDefaultPolicy_readPasswordPolicy(t *testing.T) { ri := acctest.RandInt() - config := testAccDataSourceDefaultPolicyConfig(ri) + config := testAccDataSourceDefaultPolicy(ri, sdk.PasswordPolicyType) resource.Test(t, resource.TestCase{ PreCheck: func() { @@ -30,10 +30,30 @@ func TestAccOktaDataSourceDefaultPolicy_read(t *testing.T) { }) } -func testAccDataSourceDefaultPolicyConfig(rInt int) string { +func TestAccOktaDataSourceDefaultPolicy_readIdpPolicy(t *testing.T) { + ri := acctest.RandInt() + config := testAccDataSourceDefaultPolicy(ri, sdk.IdpDiscoveryType) + + resource.Test(t, resource.TestCase{ + PreCheck: func() { + testAccPreCheck(t) + }, + ProviderFactories: testAccProvidersFactories, + Steps: []resource.TestStep{ + { + Config: config, + Check: resource.ComposeTestCheckFunc( + resource.TestCheckResourceAttrSet("data.okta_default_policy.default-"+strconv.Itoa(ri), "id"), + ), + }, + }, + }) +} + +func testAccDataSourceDefaultPolicy(rInt int, policy string) string { return fmt.Sprintf(` data "okta_default_policy" "default-%d" { type = "%s" } -`, rInt, sdk.PasswordPolicyType) +`, rInt, policy) }