Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: typo in query parameter for Okta group rule deletion API #2083

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: typo in query parameter for Okta group rule deletion API #2083

wants to merge 1 commit into from

Conversation

RGVas
Copy link

@RGVas RGVas commented Sep 12, 2024

Fixes #2082

This PR fixes a typo found when calling Okta API to delete a group rule. Currently the removeUsers query parameter is set as RemoveUsers which causes users to not be removed from groups after rule deletion.

@RGVas RGVas mentioned this pull request Sep 12, 2024
Open
@exitcode0
Copy link
Contributor

Should this have a test case?

Not trying to suggest that @RGVas should be obligated to include one in this PR
Perhaps we should create an issue/ Okta Jira as a TODO for the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

okta_group_rule.remove_assigned_users = True fails to remove users when deleting rule
2 participants
@RGVas @exitcode0