Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eventsAfter: Don't reverse events #33

Closed
taoeffect opened this issue Feb 21, 2024 · 1 comment
Closed

eventsAfter: Don't reverse events #33

taoeffect opened this issue Feb 21, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request priority:high

Comments

@taoeffect
Copy link
Member

Problem

Once okTurtles/group-income#1740 is merged, the events will no longer be returned in reverse order, so we should no longer call .reverse() in eventsAfter.ts.

Solution

After that PR is merged, update evensAfter.ts to remove the two calls to .reverse().
@taoeffect taoeffect added bug Something isn't working enhancement New feature or request priority:high labels Feb 21, 2024
@taoeffect taoeffect mentioned this issue Feb 21, 2024
Closed
@taoeffect taoeffect mentioned this issue Mar 18, 2024
Closed
@taoeffect
Copy link
Member Author

Closed by @corrideat in #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request priority:high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taoeffect