Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goodbye to Rolebtn component from CARE #4370

Closed
Tracked by #3742
patelaryan7751 opened this issue Dec 19, 2022 · 13 comments · Fixed by #5649
Closed
Tracked by #3742

Goodbye to Rolebtn component from CARE #4370

patelaryan7751 opened this issue Dec 19, 2022 · 13 comments · Fixed by #5649
Assignees
Labels
good first issue Good for newcomers

Comments

@patelaryan7751
Copy link
Contributor

Describe the bug
All Existing Rolebtn would be replaced by ButtonV2

@patelaryan7751 patelaryan7751 self-assigned this Dec 19, 2022
@mathew-alex mathew-alex added this to Care Dec 19, 2022
@mathew-alex mathew-alex moved this to Triage in Care Dec 19, 2022
@mathew-alex mathew-alex moved this from Triage to In Progress in Care Dec 19, 2022
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Jan 3, 2023
@nihal467
Copy link
Member

nihal467 commented Jan 3, 2023

@patelaryan7751 what is status of the PR

@nihal467 nihal467 removed the stale label Jan 3, 2023
@patelaryan7751
Copy link
Contributor Author

@nihal467 i would be working on it

@github-actions
Copy link

github-actions bot commented Feb 4, 2023

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions
Copy link

github-actions bot commented Apr 8, 2023

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Apr 8, 2023
@patelaryan7751 patelaryan7751 removed their assignment Apr 8, 2023
@github-actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Apr 23, 2023
@rithviknishad rithviknishad added good first issue Good for newcomers and removed stale labels May 31, 2023
@meeddhhaa
Copy link

Hi @mathew-alex @rithviknishad @nihal467 can you please provide some more information regarding this issue? I'm new here and I'd love to work on this issue.

@rithviknishad
Copy link
Member

rithviknishad commented Jun 1, 2023

@meeddhhaa some buttons are allowed only for certain user types/role. So we had a seperate RoleButton component that serves the purpose.

However, its a legacy component since it was built in early days to work along with material ui and all. Nowadays we have ButtonV2 tailwind based component which is widely used. This custom component also supports disabling based on user type, which can be specified with the authorizedFor prop.

This way we won't need to use seperate components to restrict access, just use the same ButtonV2 component and add authorizedFor=___.

This helps in keeping designs consistent and maintaining the codebase in long run.

@meeddhhaa
Copy link

meeddhhaa commented Jun 1, 2023

@rithviknishad Cool, got the gist. I'll set up the codebase and start working on this, thanks!

@rithviknishad
Copy link
Member

@meeddhhaa any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants