-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goodbye to Rolebtn component from CARE #4370
Comments
Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity. |
@patelaryan7751 what is status of the PR |
@nihal467 i would be working on it |
Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity. |
Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity. |
Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity. |
Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity. |
Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity. |
Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity. |
Hi @mathew-alex @rithviknishad @nihal467 can you please provide some more information regarding this issue? I'm new here and I'd love to work on this issue. |
@meeddhhaa some buttons are allowed only for certain user types/role. So we had a seperate However, its a legacy component since it was built in early days to work along with material ui and all. Nowadays we have This way we won't need to use seperate components to restrict access, just use the same ButtonV2 component and add authorizedFor=___. This helps in keeping designs consistent and maintaining the codebase in long run. |
@rithviknishad Cool, got the gist. I'll set up the codebase and start working on this, thanks! |
@meeddhhaa any updates on this? |
Describe the bug
All Existing Rolebtn would be replaced by ButtonV2
The text was updated successfully, but these errors were encountered: