Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goodbye CheckCircleOutline icon of material UI #4367

Closed
Tracked by #3742
rithviknishad opened this issue Dec 19, 2022 · 0 comments · Fixed by #4358
Closed
Tracked by #3742

Goodbye CheckCircleOutline icon of material UI #4367

rithviknishad opened this issue Dec 19, 2022 · 0 comments · Fixed by #4358
Assignees
@rithviknishad

Comments

@rithviknishad
Copy link
Member

Describe the bug
CheckCircleOutlineIcon is the most popularly used Material UI icon in the codebase. In effort to push out material UI, it shall be migrated to CareIcon's check / check-circle equivalent.

Expected behavior
Replace with any one of the following. (not both, as we need to be consistent with our design)

  • <CareIcon className="care-l-check text-lg" />
  • <CareIcon className="care-l-check-circle text-lg" />
@rithviknishad rithviknishad self-assigned this Dec 19, 2022
@mathew-alex mathew-alex moved this from Triage to In Progress in Care Dec 19, 2022
@mathew-alex mathew-alex moved this to Triage in Care Dec 19, 2022
@mathew-alex mathew-alex added this to Care Dec 19, 2022
This was referenced Dec 19, 2022
Merged
Closed
Repository owner moved this from In Progress to Done in Care Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rithviknishad rithviknishad

Labels
None yet
Projects
Care
Archived in project
Milestone
No milestone
1 participant
@rithviknishad