Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] multiSelectRequiresKeyboard option for toggling row selec… #160

Merged
merged 1 commit into from
Sep 7, 2016

Conversation

bargar
Copy link
Contributor

@bargar bargar commented Sep 3, 2016

…ction without ctrl/cmd

shift-click to select multiple intervening rows works as always

As discussed in #147.

…tion without ctrl/cmd

shift-click to select multiple intervening rows works as always
@@ -24,7 +24,7 @@ test('it renders', function(assert) {
assert.equal(this.$().text().trim(), '');
});

test('row selection', function(assert) {
test('row selection - enable or disable', function(assert) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than have three tests called 'row selection' I took the liberty of adding additional detail to these test names to differentiate them

@offirgolan
Copy link
Collaborator

@bargar thank you for taking the time in putting this together. Overall, I think the PR looks great! I really appreciate the extra test cases 😸

Before I merge this, I'd like to pull your branch just so I can get a feel for the feature. I'll prolly do that after this long weekend and we can go from there!

@offirgolan offirgolan merged commit 3a4ce56 into adopted-ember-addons:master Sep 7, 2016
offirgolan added a commit that referenced this pull request Sep 7, 2016
* master:
  [FEATURE] `multiSelectRequiresKeyboard` option for toggling row
selection without ctrl/cmd (#160)
  chore(package): update ember-cli-blanket to version 0.9.9 (#162)

# Conflicts:
#	package.json
Gorzas pushed a commit to Gorzas/ember-light-table that referenced this pull request Sep 8, 2016
…tion without ctrl/cmd (adopted-ember-addons#160)

shift-click to select multiple intervening rows works as always
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants