Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations + Some cleanup #122

Merged
merged 2 commits into from
Jul 27, 2016
Merged

Remove deprecations + Some cleanup #122

merged 2 commits into from
Jul 27, 2016

Conversation

offirgolan
Copy link
Collaborator

Resolves #100

  • Renamed lt-column-resize to lt-column-resizer
  • Fixed deprecation warning caused by checking fixedHeader & fixedFooter twice on the same render
  • Fixed deprecation caused by multiple renders in lt-infinity by forcing each observer call to execute on the afterRender queue of the run loop

@taras
Copy link
Collaborator

taras commented Jul 27, 2016

It's unfortunate that we need to do all of this hackary with the runloop to get this to work properly. Hopefully we'll find another approach in the future.

@taras taras merged commit 80462dd into master Jul 27, 2016
@taras taras deleted the lt-infinity-changes branch July 27, 2016 03:14
@offirgolan
Copy link
Collaborator Author

@taras I agree but I think the current implementation is rather clean and self explanatory. Maybe in the future we can think of a better way to do the whole sharedOptions stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecation warning in tests
2 participants