Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TechEmpower Benchmarks Fortunes is not using a templating #1403

Open
agentgt opened this issue May 17, 2023 · 2 comments
Open

TechEmpower Benchmarks Fortunes is not using a templating #1403

agentgt opened this issue May 17, 2023 · 2 comments

Comments

@agentgt
Copy link

agentgt commented May 17, 2023

I am a great admirer of your framework and saw how well you did on TechEmpower but I'm saddened that you borderline cheated (in spirit) on the Fortune benchmark.

You are supposed to use a templating language and not just hard code Java strings as bytes.

Anyway I think you will get similar results to your hard coding if you use Rocker or my templating engine JStachio (both pre-encode like you manually did albeit mine needs an experimental flag turned on JStacheFlags(flags=PRE_ENCODE)).

Here is some JMH benchmarking:
https://github.com/agentgt/template-benchmark

If you are interested I can try to plug it in the TechEmpower Framework code as branch/PR.

@HenkPoley
Copy link

I would also note that in TechEmpower Round 22, OfficeFloor somehow didn't do so well: https://www.techempower.com/benchmarks/#hw=ph&test=cached-query&section=data-r22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants