Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Brightness Setting #6

Closed
hugoender opened this issue Jun 5, 2023 · 3 comments
Closed

Feature Request: Brightness Setting #6

hugoender opened this issue Jun 5, 2023 · 3 comments

Comments

@hugoender
Copy link

Add brightness setting to settings page. The default brightness of 1 (minimum) is a bit too dim when using the device in well lit areas. I understand that making the display brighter may make the QR codes harder to read for some cameras so my recommendation for that is to lower the brightness when the device displays a QR code.

@bitcoinheiro
Copy link

Current brightness is great for phone reading, but I was testing a multisig setup the other day and loved that Krux saved the descriptor and also showed the QR code of the descriptor for exporting after it was loaded. I thought I would be able to use it to export to other signing devices, but the problem is that other simpler devices with low-res camera do need brighter QR codes to be able to import the descriptor. - so maybe some sort of brigthness setting on-the-fly, when the QR is showing, would be the best approach

@odudex
Copy link
Owner

odudex commented Jul 11, 2023

Current brightness is great for phone reading, but I was testing a multisig setup the other day and loved that Krux saved the descriptor and also showed the QR code of the descriptor for exporting after it was loaded. I thought I would be able to use it to export to other signing devices, but the problem is that other simpler devices with low-res camera do need brighter QR codes to be able to import the descriptor. - so maybe some sort of brigthness setting on-the-fly, when the QR is showing, would be the best approach

Currently the animated QR codes toggle brightness mode when PAGE(down-next) button is pressed, as it is with the camera's "anti-glare" mode. I think it is a good idea to add this feature to static QR codes as well. For now what you can do is use the light theme, which is better suited for brighter environments. In light theme all QR codes will be brighter by default.

@odudex
Copy link
Owner

odudex commented Apr 17, 2024

Backlight brightness control is now available on beta, for M5stickV and Cube

@odudex odudex closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants