Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quaternion implementation errors *bug* #1644

Closed
Roderic-V opened this issue Mar 22, 2022 · 0 comments
Closed

Quaternion implementation errors *bug* #1644

Roderic-V opened this issue Mar 22, 2022 · 0 comments

Comments

@Roderic-V
Copy link

Context

dev-2022-03
Windows 10 x64

Expected Behavior

angle_from_quaternion_* return correct angle

Current Behavior

angle_from_quaternion_* return incorrect angle due to a bug in implementation, it returns math.acos(q.x) * 2, but it should be acos(q.w)

(Shouldn't odin offer unit tests as part of the core language BTW ?)
@Roderic-V Roderic-V changed the title Quaternion implementation errors Quaternion implementation errors *bug* Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Roderic-V