From 151e0e067c56126954b87aa71c6643f90ff4b834 Mon Sep 17 00:00:00 2001 From: Amir Blum Date: Sat, 2 Dec 2023 13:13:52 +0200 Subject: [PATCH] chore: remove github token from makefile as they are unused --- Makefile | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 0bfa94274..237f5edfc 100644 --- a/Makefile +++ b/Makefile @@ -1,9 +1,9 @@ .PHONY: build-images build-images: - docker build -t keyval/odigos-autoscaler:$(TAG) . --build-arg SERVICE_NAME=autoscaler --build-arg GITHUB_TOKEN=${GITHUB_TOKEN} - docker build -t keyval/odigos-scheduler:$(TAG) . --build-arg SERVICE_NAME=scheduler --build-arg GITHUB_TOKEN=${GITHUB_TOKEN} - docker build -t keyval/odigos-odiglet:$(TAG) . -f odiglet/Dockerfile --build-arg GITHUB_TOKEN=${GITHUB_TOKEN} - docker build -t keyval/odigos-instrumentor:$(TAG) . --build-arg SERVICE_NAME=instrumentor --build-arg GITHUB_TOKEN=${GITHUB_TOKEN} + docker build -t keyval/odigos-autoscaler:$(TAG) . --build-arg SERVICE_NAME=autoscaler + docker build -t keyval/odigos-scheduler:$(TAG) . --build-arg SERVICE_NAME=scheduler + docker build -t keyval/odigos-odiglet:$(TAG) . -f odiglet/Dockerfile + docker build -t keyval/odigos-instrumentor:$(TAG) . --build-arg SERVICE_NAME=instrumentor .PHONY: push-images push-images: @@ -21,9 +21,9 @@ load-to-kind: .PHONY: debug-odiglet debug-odiglet: - docker build -t keyval/odigos-odiglet:$(TAG) . -f odiglet/debug.Dockerfile --build-arg GITHUB_TOKEN=${GITHUB_TOKEN} + docker build -t keyval/odigos-odiglet:$(TAG) . -f odiglet/debug.Dockerfile kind load docker-image keyval/odigos-odiglet:$(TAG) kubectl rollout restart daemonset odiglet -n odigos-system kubectl wait --for=condition=ready pod -l app=odiglet -n odigos-system - $(eval POD_NAME := $(shell kubectl get pods -n odigos-system -l app=odiglet -o jsonpath='{.items[0].metadata.name}')) + $(eval POD_NAME := $(shell kubectl get pods -n odigos-system --field-selector=status.phase=Running -l app=odiglet -o jsonpath='{.items[0].metadata.name}')) kubectl port-forward -n odigos-system $(POD_NAME) 2345:2345 \ No newline at end of file