From 412b216e8341859e5a7a12fd7b5f4f0753570eba Mon Sep 17 00:00:00 2001 From: Endre Sara Date: Sun, 7 Jul 2024 09:37:12 -0400 Subject: [PATCH] handle unknown programming language in odiglet (#1331) address https://github.com/odigos-io/odigos/issues/1330 Co-authored-by: esara Co-authored-by: Amir Blum --- odiglet/pkg/kube/runtime_details/shared.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/odiglet/pkg/kube/runtime_details/shared.go b/odiglet/pkg/kube/runtime_details/shared.go index 716cfa351..17306d766 100644 --- a/odiglet/pkg/kube/runtime_details/shared.go +++ b/odiglet/pkg/kube/runtime_details/shared.go @@ -95,17 +95,17 @@ func runtimeInspection(pods []corev1.Pod, ignoredContainers []string) ([]odigosv } } + envs := make([]odigosv1.EnvVar, 0) if inspectProc == nil { log.Logger.V(0).Info("unable to detect language for any process", "pod", pod.Name, "container", container.Name, "namespace", pod.Namespace) lang = common.UnknownProgrammingLanguage } else if len(processes) > 1 { log.Logger.V(0).Info("multiple processes found in pod container, only taking the first one with detected language into account", "pod", pod.Name, "container", container.Name, "namespace", pod.Namespace) - } - - // Convert map to slice for k8s format - envs := make([]odigosv1.EnvVar, 0, len(inspectProc.Envs)) - for envName, envValue := range inspectProc.Envs { - envs = append(envs, odigosv1.EnvVar{Name: envName, Value: envValue}) + // Convert map to slice for k8s format + envs = make([]odigosv1.EnvVar, 0, len(inspectProc.Envs)) + for envName, envValue := range inspectProc.Envs { + envs = append(envs, odigosv1.EnvVar{Name: envName, Value: envValue}) + } } resultsMap[container.Name] = odigosv1.RuntimeDetailsByContainer{