[MAINT]: Rename find_app_installations to list_app_installations

[pbstriker38]

Describe the need

All the other index endpoints start with list_. I always need to come and search the code to figure out the name of this one.

This is also referred to as listing installations in the API documentation.

https://docs.github.com/en/rest/apps/apps?apiVersion=2022-11-28#list-installations-for-the-authenticated-app

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[kfcampbell]

Perhaps we could alias that function for now to avoid a breaking change, and remove find_app_installations in a future release.

[pbstriker38]

That sounds good to me

[pbstriker38]

@kfcampbell Would you like me to open a PR for that?

[kfcampbell]

If you have the time and inclination, that would be wonderful!

[pbstriker38]

@kfcampbell
As I was working on the alias I noticed that the apps endpoint have a few deprecations that have existed since v4.8.0. These should probably be removed by now since it will be odd that a deprecated method points to another method that could also become deprecated soon.

There's actually a few deprecated methods that have existed since integrations was renamed to apps.

https://github.com/octokit/octokit.rb/blob/v9.2.0/lib/octokit/client/apps.rb#L30
https://github.com/octokit/octokit.rb/releases/tag/v4.8.0