Deprecation warning since Faraday 1.7.1

[ybiquitous]

Since Faraday 1.7.1, the following methods of the Faraday::Connection class emits a deprecation warning:

• #basic_auth
• #token_auth
• #authorization

See also PR lostisland/faraday#1306

When running the specs on my local machine with the current HEAD revision (605a08a), we can see the many warnings:

$ bundle exec rspec
...
WARNING: `Faraday::Connection#authorization` is deprecated; it will be removed in version 2.0.
While initializing your connection, use `#request(:authorization, ...)` instead.
See https://lostisland.github.io/faraday/middleware/authentication for more usage info.
...

Used gem versions are as below:

$ bundle list | grep faraday
  * faraday (1.7.1)
  * faraday-em_http (1.0.0)
  * faraday-em_synchrony (1.0.0)
  * faraday-excon (1.1.0)
  * faraday-httpclient (1.0.1)
  * faraday-net_http (1.0.1)
  * faraday-net_http_persistent (1.2.0)
  * faraday-patron (1.0.0)
  * faraday-rack (1.0.0)

I think Octokit needs to fix the warnings to prevent users' application logs from being flooded with them.

[ybiquitous]

These methods have been deleted on Faraday HEAD: lostisland/faraday#1308

[xiaoxipang]

Thanks for the fix! Looking forward to seeing this PR merging in soon because we use tons of octokit APIs and got tons of warnings now :p

[unicornzero]

I'm seeing a lot of deprecation warnings now that I've had to update faraday because of a critical dependency. Is there any word on getting this change into a release soon?

[claybridges]

In the meantime, I fixed this in my own usage (scripts) by putting this in my Gemfile:

gem 'octokit'
gem 'faraday', '1.7.0'

[kaiomagalhaes]

@ybiquitous thanks for your solution on: https://github.com/ybiquitous/octokit.rb/tree/issue-1357

I'll be using it until we get a final solution on master.