From 733b5b54650baf8029e1361c37fb92dac17cb6a7 Mon Sep 17 00:00:00 2001 From: Nick Floyd <139819+nickfloyd@users.noreply.github.com> Date: Fri, 29 Sep 2023 14:09:18 -0500 Subject: [PATCH] rubocop fixes --- lib/octokit/client/apps.rb | 2 +- spec/octokit/client/apps_spec.rb | 41 ++++++++++++++++---------------- 2 files changed, 21 insertions(+), 22 deletions(-) diff --git a/lib/octokit/client/apps.rb b/lib/octokit/client/apps.rb index 16eca1038..6464d9cbd 100644 --- a/lib/octokit/client/apps.rb +++ b/lib/octokit/client/apps.rb @@ -226,7 +226,7 @@ def delete_installation(installation, options = {}) # # @return [Array] an array of hook deliveries def list_app_hook_deliveries(options = {}) - paginate("app/hook/deliveries", options) do |data, last_response| + paginate('app/hook/deliveries', options) do |data, last_response| data.concat last_response.data end end diff --git a/spec/octokit/client/apps_spec.rb b/spec/octokit/client/apps_spec.rb index a92d7059f..8c84a706d 100644 --- a/spec/octokit/client/apps_spec.rb +++ b/spec/octokit/client/apps_spec.rb @@ -182,29 +182,29 @@ end end # .find_user_installation - describe '.list_app_hook_deliveries', :vcr do - it 'lists hook deliveries for an app' do - response = @jwt_client.list_app_hook_deliveries - expect(response).to be_kind_of(Array) - expect(response.count).to eq 2 - end + describe '.list_app_hook_deliveries', :vcr do + it 'lists hook deliveries for an app' do + response = @jwt_client.list_app_hook_deliveries + expect(response).to be_kind_of(Array) + expect(response.count).to eq 2 + end - it 'allows auto_pagination' do - @jwt_client.auto_paginate = true - response = @jwt_client.list_app_hook_deliveries(per_page: 1) + it 'allows auto_pagination' do + @jwt_client.auto_paginate = true + response = @jwt_client.list_app_hook_deliveries(per_page: 1) - expect(response).to be_kind_of(Array) - expect(response.count).to eq 3 - end - end #.list_app_hook_deliveries + expect(response).to be_kind_of(Array) + expect(response.count).to eq 3 + end + end # .list_app_hook_deliveries - describe '.deliver_app_hook', :vcr do - let(:delivery_id) { 55148726666 } - it 'schedules a webhook for redelivery' do - response = @jwt_client.deliver_app_hook(delivery_id) - expect(response).to be_truthy - end - end #.deliver_app_hook + describe '.deliver_app_hook', :vcr do + let(:delivery_id) { 55_148_726_666 } + it 'schedules a webhook for redelivery' do + response = @jwt_client.deliver_app_hook(delivery_id) + expect(response).to be_truthy + end + end # .deliver_app_hook context 'with app installation', :vcr do let(:installation) { test_github_integration_installation } @@ -302,7 +302,6 @@ end end # .delete_installation - context 'with app installation access token' do let(:installation_client) do token = @jwt_client.create_app_installation_access_token(installation).token