fix: comment id model update to long instead of int

* #2927: comment id model update to long instead of int

* #2927: code review fixes (1)

* #2927: code review fixes (2)

* #2927: comment id model update to long instead of int: unit tests fix

* #2927: code review fixes

* Fixed most names of parameters

---------

Co-authored-by: Victor Vorobyev <victor@myrtle-sa.com>
Co-authored-by: Brian C. Arnold <brian.arnold@spiderrock.net>

Octokit.Reactive/Clients/IObservableCommitCommentReactionsClient.cs

@@ -17,60 +17,60 @@ public interface IObservableCommitCommentReactionsClient
         /// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-a-commit-comment</remarks>
         /// <param name="owner">The owner of the repository</param>
         /// <param name="name">The name of the repository</param>
-        /// <param name="number">The comment id</param>
+        /// <param name="commentId">The comment id</param>
         /// <param name="reaction">The reaction to create </param>
         /// <returns></returns>
-        IObservable<Reaction> Create(string owner, string name, int number, NewReaction reaction);
+        IObservable<Reaction> Create(string owner, string name, long commentId, NewReaction reaction);
 
         /// <summary>
         /// Creates a reaction for a specified Commit Comment
         /// </summary>
         /// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-a-commit-comment</remarks>
         /// <param name="repositoryId">The Id of the repository</param>
-        /// <param name="number">The comment id</param>
+        /// <param name="commentId">The comment id</param>
         /// <param name="reaction">The reaction to create </param>
         /// <returns></returns>
-        IObservable<Reaction> Create(long repositoryId, int number, NewReaction reaction);
+        IObservable<Reaction> Create(long repositoryId, long commentId, NewReaction reaction);
 
         /// <summary>
         /// List reactions for a specified Commit Comment
         /// </summary>
         /// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
         /// <param name="owner">The owner of the repository</param>
         /// <param name="name">The name of the repository</param>
-        /// <param name="number">The comment id</param>
+        /// <param name="commentId">The comment id</param>
         /// <returns></returns>
-        IObservable<Reaction> GetAll(string owner, string name, int number);
+        IObservable<Reaction> GetAll(string owner, string name, long commentId);
 
         /// <summary>
         /// List reactions for a specified Commit Comment
         /// </summary>
         /// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
         /// <param name="owner">The owner of the repository</param>
         /// <param name="name">The name of the repository</param>
-        /// <param name="number">The comment id</param>
+        /// <param name="commentId">The comment id</param>
         /// <param name="options">Options for changing the API response</param>
         /// <returns></returns>
-        IObservable<Reaction> GetAll(string owner, string name, int number, ApiOptions options);
+        IObservable<Reaction> GetAll(string owner, string name, long commentId, ApiOptions options);
 
         /// <summary>
         /// List reactions for a specified Commit Comment
         /// </summary>
         /// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
         /// <param name="repositoryId">The owner of the repository</param>
-        /// <param name="number">The comment id</param>
+        /// <param name="commentId">The comment id</param>
         /// <returns></returns>
-        IObservable<Reaction> GetAll(long repositoryId, int number);
+        IObservable<Reaction> GetAll(long repositoryId, long commentId);
 
         /// <summary>
         /// List reactions for a specified Commit Comment
         /// </summary>
         /// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
         /// <param name="repositoryId">The owner of the repository</param>
-        /// <param name="number">The comment id</param>
+        /// <param name="commentId">The comment id</param>
         /// <param name="options">Options for changing the API response</param>
         /// <returns></returns>
-        IObservable<Reaction> GetAll(long repositoryId, int number, ApiOptions options);
+        IObservable<Reaction> GetAll(long repositoryId, long commentId, ApiOptions options);
 
         /// <summary>
         /// Deletes a reaction for a specified Commit Comment
@@ -81,7 +81,7 @@ public interface IObservableCommitCommentReactionsClient
         /// <param name="commentId">The comment id</param>
         /// <param name="reactionId">The reaction id</param>
         /// <returns></returns>
-        IObservable<Unit> Delete(string owner, string name, int commentId, int reactionId);
+        IObservable<Unit> Delete(string owner, string name, long commentId, long reactionId);
 
         /// <summary>
         /// Deletes a reaction for a specified Commit Comment
@@ -91,6 +91,6 @@ public interface IObservableCommitCommentReactionsClient
         /// <param name="commentId">The comment id</param>
         /// <param name="reactionId">The reaction id</param>
         /// <returns></returns>
-        IObservable<Unit> Delete(long repositoryId, int commentId, int reactionId);
+        IObservable<Unit> Delete(long repositoryId, long commentId, long reactionId);
     }
 }

Octokit.Reactive/Clients/IObservableGistCommentsClient.cs

@@ -15,7 +15,7 @@ public interface IObservableGistCommentsClient
         /// <returns>IObservable{GistComment}.</returns>
         [SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
             Justification = "Method makes a network request")]
-        IObservable<GistComment> Get(string gistId, int commentId);
+        IObservable<GistComment> Get(string gistId, long commentId);
 
         /// <summary>
         /// Gets all comments for the gist with the specified id.
@@ -51,7 +51,7 @@ public interface IObservableGistCommentsClient
         /// <param name="commentId">The id of the comment</param>
         /// <param name="comment">The updated body of the comment</param>
         /// <returns>IObservable{GistComment}.</returns>
-        IObservable<GistComment> Update(string gistId, int commentId, string comment);
+        IObservable<GistComment> Update(string gistId, long commentId, string comment);
 
         /// <summary>
         /// Deletes the comment with the specified gist- and comment id.
@@ -60,6 +60,6 @@ public interface IObservableGistCommentsClient
         /// <param name="gistId">The id of the gist</param>
         /// <param name="commentId">The id of the comment</param>
         /// <returns>IObservable{Unit}.</returns>
-        IObservable<Unit> Delete(string gistId, int commentId);
+        IObservable<Unit> Delete(string gistId, long commentId);
     }
 }

Octokit.Reactive/Clients/IObservableIssueCommentReactionsClient.cs

@@ -17,54 +17,54 @@ public interface IObservableIssueCommentReactionsClient
         /// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue-comment</remarks>
         /// <param name="owner">The owner of the repository</param>
         /// <param name="name">The name of the repository</param>
-        /// <param name="number">The comment id</param>
+        /// <param name="commentId">The comment id</param>
         /// <param name="reaction">The reaction to create </param>
-        IObservable<Reaction> Create(string owner, string name, int number, NewReaction reaction);
+        IObservable<Reaction> Create(string owner, string name, long commentId, NewReaction reaction);
 
         /// <summary>
         /// Creates a reaction for a specified Issue Comment
         /// </summary>
         /// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue-comment</remarks>
         /// <param name="repositoryId">The Id of the repository</param>
-        /// <param name="number">The comment id</param>
+        /// <param name="commentId">The comment id</param>
         /// <param name="reaction">The reaction to create </param>
-        IObservable<Reaction> Create(long repositoryId, int number, NewReaction reaction);
+        IObservable<Reaction> Create(long repositoryId, long commentId, NewReaction reaction);
 
         /// <summary>
         /// List reactions for a specified Issue Comment
         /// </summary>
         /// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
         /// <param name="owner">The owner of the repository</param>
         /// <param name="name">The name of the repository</param>
-        /// <param name="number">The comment id</param>
-        IObservable<Reaction> GetAll(string owner, string name, int number);
+        /// <param name="commentId">The comment id</param>
+        IObservable<Reaction> GetAll(string owner, string name, long commentId);
 
         /// <summary>
         /// List reactions for a specified Issue Comment
         /// </summary>
         /// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
         /// <param name="owner">The owner of the repository</param>
         /// <param name="name">The name of the repository</param>
-        /// <param name="number">The comment id</param>
+        /// <param name="commentId">The comment id</param>
         /// <param name="options">Options for changing the API response</param>
-        IObservable<Reaction> GetAll(string owner, string name, int number, ApiOptions options);
+        IObservable<Reaction> GetAll(string owner, string name, long commentId, ApiOptions options);
 
         /// <summary>
         /// List reactions for a specified Issue Comment
         /// </summary>
         /// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
         /// <param name="repositoryId">The Id of the repository</param>
-        /// <param name="number">The comment id</param>
-        IObservable<Reaction> GetAll(long repositoryId, int number);
+        /// <param name="commentId">The comment id</param>
+        IObservable<Reaction> GetAll(long repositoryId, long commentId);
 
         /// <summary>
         /// List reactions for a specified Issue Comment
         /// </summary>
         /// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
         /// <param name="repositoryId">The Id of the repository</param>
-        /// <param name="number">The comment id</param>
+        /// <param name="commentId">The comment id</param>
         /// <param name="options">Options for changing the API response</param>
-        IObservable<Reaction> GetAll(long repositoryId, int number, ApiOptions options);
+        IObservable<Reaction> GetAll(long repositoryId, long commentId, ApiOptions options);
 
         /// <summary>
         /// Deletes a reaction for a specified Issue Comment
@@ -75,7 +75,7 @@ public interface IObservableIssueCommentReactionsClient
         /// <param name="commentId">The comment id</param>
         /// <param name="reactionId">The reaction id</param>
         /// <returns></returns>
-        IObservable<Unit> Delete(string owner, string name, int commentId, int reactionId);
+        IObservable<Unit> Delete(string owner, string name, long commentId, long reactionId);
 
         /// <summary>
         /// Deletes a reaction for a specified Commit Comment
@@ -85,6 +85,6 @@ public interface IObservableIssueCommentReactionsClient
         /// <param name="commentId">The comment id</param>
         /// <param name="reactionId">The reaction id</param>
         /// <returns></returns>
-        IObservable<Unit> Delete(long repositoryId, int commentId, int reactionId);
+        IObservable<Unit> Delete(long repositoryId, long commentId, long reactionId);
     }
 }

Octokit.Reactive/Clients/IObservableIssueCommentsClient.cs

@@ -18,20 +18,20 @@ public interface IObservableIssueCommentsClient
         /// <remarks>http://developer.github.com/v3/issues/comments/#get-a-single-comment</remarks>
         /// <param name="owner">The owner of the repository</param>
         /// <param name="name">The name of the repository</param>
-        /// <param name="id">The issue comment id</param>
+        /// <param name="commentId">The issue comment id</param>
         [SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
             Justification = "Method makes a network request")]
-        IObservable<IssueComment> Get(string owner, string name, int id);
+        IObservable<IssueComment> Get(string owner, string name, long commentId);
 
         /// <summary>
         /// Gets a single Issue Comment by id.
         /// </summary>
         /// <remarks>http://developer.github.com/v3/issues/comments/#get-a-single-comment</remarks>
         /// <param name="repositoryId">The Id of the repository</param>
-        /// <param name="id">The issue comment id</param>
+        /// <param name="commentId">The issue comment id</param>
         [SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
             Justification = "Method makes a network request")]
-        IObservable<IssueComment> Get(long repositoryId, int id);
+        IObservable<IssueComment> Get(long repositoryId, long commentId);
 
         /// <summary>
         /// Gets Issue Comments for a repository.
@@ -202,34 +202,34 @@ public interface IObservableIssueCommentsClient
         /// <remarks>http://developer.github.com/v3/issues/comments/#edit-a-comment</remarks>
         /// <param name="owner">The owner of the repository</param>
         /// <param name="name">The name of the repository</param>
-        /// <param name="id">The comment id</param>
+        /// <param name="commentId">The comment id</param>
         /// <param name="commentUpdate">The modified comment</param>
-        IObservable<IssueComment> Update(string owner, string name, int id, string commentUpdate);
+        IObservable<IssueComment> Update(string owner, string name, long commentId, string commentUpdate);
 
         /// <summary>
         /// Updates a specified Issue Comment.
         /// </summary>
         /// <remarks>http://developer.github.com/v3/issues/comments/#edit-a-comment</remarks>
         /// <param name="repositoryId">The Id of the repository</param>
-        /// <param name="id">The comment id</param>
+        /// <param name="commentId">The comment id</param>
         /// <param name="commentUpdate">The modified comment</param>
-        IObservable<IssueComment> Update(long repositoryId, int id, string commentUpdate);
+        IObservable<IssueComment> Update(long repositoryId, long commentId, string commentUpdate);
 
         /// <summary>
         /// Deletes the specified Issue Comment
         /// </summary>
         /// <remarks>http://developer.github.com/v3/issues/comments/#delete-a-comment</remarks>
         /// <param name="owner">The owner of the repository</param>
         /// <param name="name">The name of the repository</param>
-        /// <param name="id">The comment id</param>
-        IObservable<Unit> Delete(string owner, string name, int id);
+        /// <param name="commentId">The comment id</param>
+        IObservable<Unit> Delete(string owner, string name, long commentId);
 
         /// <summary>
         /// Deletes the specified Issue Comment
         /// </summary>
         /// <remarks>http://developer.github.com/v3/issues/comments/#delete-a-comment</remarks>
         /// <param name="repositoryId">The Id of the repository</param>
-        /// <param name="id">The comment id</param>
-        IObservable<Unit> Delete(long repositoryId, int id);
+        /// <param name="commentId">The comment id</param>
+        IObservable<Unit> Delete(long repositoryId, long commentId);
     }
 }

Octokit.Reactive/Clients/IObservableIssueReactionsClient.cs

@@ -75,7 +75,7 @@ public interface IObservableIssueReactionsClient
         /// <param name="issueNumber">The issue number</param>
         /// <param name="reactionId">The reaction id</param>
         /// <returns></returns>
-        IObservable<Unit> Delete(string owner, string name, int issueNumber, int reactionId);
+        IObservable<Unit> Delete(string owner, string name, int issueNumber, long reactionId);
 
         /// <summary>
         /// Deletes a reaction for a specified Issue
@@ -85,6 +85,6 @@ public interface IObservableIssueReactionsClient
         /// <param name="issueNumber">The issue number</param>
         /// <param name="reactionId">The reaction id</param>
         /// <returns></returns>
-        IObservable<Unit> Delete(long repositoryId, int issueNumber, int reactionId);
+        IObservable<Unit> Delete(long repositoryId, int issueNumber, long reactionId);
     }
 }