Add test for handling partial data with error(s) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
reviewed
Apr 4, 2019
|
|
||
| .then(result => { | ||
| throw new Error('Should not resolve') | ||
| }) |
There was a problem hiding this comment.
if you agree, we could add a .catch() statement similar to the test above, only also check for error.data. Would that be a desired behavior for partial responses?
Suggested change
| }) | |
| }) | |
| .catch(error => { | |
| expect(error.message).to.equal('Field \'bioHtml\' doesn\'t exist on type \'User\'') | |
| expect(error.errors).to.deep.equal(mockResponse.errors) | |
| expect(error.request.query).to.equal(query) | |
| expect(error.data).to.deep.equal(mockResponse.data) | |
| }) |
There was a problem hiding this comment.
Yes, I think that would make the most sense!
|
@gr2m I updated the test and made it pass, I also added a section to the readme. Let me know what you think :) |
gr2m
approved these changes
Apr 5, 2019
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #14