fix: don’t send empty variables object

octokit · Jan 8, 2019 · af96d49 · af96d49
1 parent 295da93
commit af96d49
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/lib/graphql.js b/lib/graphql.js
@@ -5,24 +5,25 @@ const GraphqlError = require('./error')
 const NON_VARIABLE_OPTIONS = ['method', 'baseUrl', 'url', 'headers', 'request', 'query']
 
 function graphql (request, query, options) {
-  const requestOptions = {
-    variables: {}
-  }
-
   if (typeof query === 'string') {
     options = Object.assign({ query }, options)
   } else {
     options = query
   }
 
-  Object.keys(options).forEach(key => {
+  const requestOptions = Object.keys(options).reduce((result, key) => {
     if (NON_VARIABLE_OPTIONS.includes(key)) {
-      requestOptions[key] = options[key]
-      return
+      result[key] = options[key]
+      return result
+    }
+
+    if (!result.variables) {
+      result.variables = {}
     }
 
-    requestOptions.variables[key] = options[key]
-  })
+    result.variables[key] = options[key]
+    return result
+  }, {})
 
   return request(requestOptions)
     .then(response => {