Cannot reorder docking tab (focus/id conflict)

[r-lyeh]

At some point one of my tabs went out of focus even if no other tab was overlapping at all. Couldnt give that bar any kind of focus with mouse. Fixed it by reordering layout of surronding tabs. Cannot give repro steps for this.

Originally posted by @r-lyeh in #2353 (comment)

[r-lyeh]

I dunno if it is related to this very same issue but I found another tab of mine which, once docked, won't move or detach anymore. I suspect the two issues are related maybe?

PS: I'd like to create a small test case for this, but it may be just much easier if you just recompile my editor and give it a go? the tab that wont undock is the 'log' tab :D

[ocornut]

I cannot take the first bug without more information (screenshot/repro).

The second one we established your code was stealing the active widget every frame.

[r-lyeh]

Got a tab that was auto stealing focus and preventing from undocking. Thx Omar :D

[r-lyeh]

The issue persists after disabling all auto-focus code.
Oddly enough, these are the lines that prevent Log tab from undocking, ideas?

static ImGuiTextFilter filter;

ImGui::PushStyleVar(ImGuiStyleVar_FramePadding, ImVec2(0,0));
filter.Draw("", -1); // <-- comment to fix issue
ImGui::PopStyleVar();

[ocornut]

OK.

So, by using an empty ID "" at the root of the window you are currently conflicting with the window itself which uses "window_name" as an ID for the tab. Your InputText will use "window_name" + "" which is the same.

You should always use an ID for your element, e.g
filter.Draw("##blah", -1);

I have an ongoing task to make tabs use a different ID e.g. ("window_name" + "##TAB") to make this kind of error less problematic.

Been also considering changing my mind on #1414 because even though there are legit use, people make this error of using empty ID too frequently.