Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetadataEventProcessor should add nft field to the ddo when saving in db #404

Closed
mariacarmina opened this issue Apr 24, 2024 · 3 comments
Closed
Assignees

Comments

@mariacarmina
Copy link
Member

MetadataEventProcessor should add nft field to the ddo when saving in db. Right now we add only nftAddress, did, chainId https://github.com/oceanprotocol/ocean-node/blob/develop/src/components/Indexer/processor.ts#L310.
nft field should be build in MetadataEventProcessor as well.

@bogdanfazakas
Copy link
Member

bogdanfazakas commented Apr 25, 2024

but do we really need to have this in the ocean node MetadataEventProcessor process event?
When i went through current aquarius codebase i have not seen this logic there, and also in our current publish flows Ocean Market for eg we create the nft object there see https://github.com/oceanprotocol/market/blob/main/src/%40utils/nft.ts#L49 .
I've seen the question from enterpise team but i think the proper response there would have been that the one publishing is reponsible for adding the NFT in the DDO .

@mariacarmina
Copy link
Member Author

From my point of view, it would be nice to have, since MetadataEventProcessor sets the nftAddress which is mandatory, we can also set nft field as well along with active state and it should not be a massive change at the first glance, but let's see if we can let in pending issues (for future ref or first good issues) or close it

@alexcos20 can you share your opinion regarding this?

@mariacarmina
Copy link
Member Author

  • did overwrite as well in indexer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants