You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
but do we really need to have this in the ocean node MetadataEventProcessor process event?
When i went through current aquarius codebase i have not seen this logic there, and also in our current publish flows Ocean Market for eg we create the nft object there see https://github.com/oceanprotocol/market/blob/main/src/%40utils/nft.ts#L49 .
I've seen the question from enterpise team but i think the proper response there would have been that the one publishing is reponsible for adding the NFT in the DDO .
From my point of view, it would be nice to have, since MetadataEventProcessor sets the nftAddress which is mandatory, we can also set nft field as well along with active state and it should not be a massive change at the first glance, but let's see if we can let in pending issues (for future ref or first good issues) or close it
@alexcos20 can you share your opinion regarding this?
MetadataEventProcessor should add
nft
field to the ddo when saving in db. Right now we add only nftAddress, did, chainId https://github.com/oceanprotocol/ocean-node/blob/develop/src/components/Indexer/processor.ts#L310.nft
field should be build in MetadataEventProcessor as well.The text was updated successfully, but these errors were encountered: