-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ocaml 4.08 #185
Comments
Is this dependent on ppx_tools getting 4.08 support? From an outsider looking in, it's quite hard to see how bits of the ppx ecosystem depend on each other, but |
@MattWindsor91 there is an open PR on ppx_tools for 4.08 support: ocaml-ppx/ppx_tools#70 |
with ppx_tools not failing to install, I get this on ppx_deriving.
maybe I have to pin ppx_deriving too? |
I started to push some changes (like @hhugo's above, but trying to be backward-compatible) in a personal branch https://github.com/gasche/ppx_deriving/tree/4.08-support. Not ready yet. I trid to investigate the deprecation warnings that show up while building ppx_deriving; I suspect that they may not all be related to the ppx_deriving codebase itself -- maybe there are parts of ppx_tools still inserting Pervasives reference. To be investigated. |
There was indeed a ppx_tool issue: ocaml-ppx/ppx_tools#72 |
I sent a 4.08-support PR in #193. |
@hhugo would you by chance be willing to review #193? Anyone else is of course welcome. I'm also interested in reports from users trying the pin on their own |
@gasche just wanted to give an update: I'm using the pins on some of my research code, and they are working great! Happy to have both |
Thanks! In the light of this glowing user review, I went ahead and merged the branch -- so now pinning ppx_deriving#master should be enough. I'll try to make a release next week -- leaving the issue open until that happens. |
can this be closed ? |
Check hhugo@4f80767 to see how much changes are required.
The text was updated successfully, but these errors were encountered: