Windows vendor stubs #530
Merged
Windows vendor stubs #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
May 28, 2023
This patch has been lingering externally since 2016 (ocaml/ocamlbuild#70), and Windows builds don't get very far without it any more, and it's blocking development of other upstream Windows ports (ocaml-multicore/eio#530). So barring strong objections, I'd like to pull this into opam-repository mainline. No version bump required since it only patches Windows, which is broken anyway without this fix. Source patch from https://github.com/fdopen/opam-repository-mingw/blob/opam2/packages/ocamlbuild/ocamlbuild.0.14.2/opam
|
Time to ditch that last pin-depends! ocaml/opam-repository#23832 |
avsm
approved these changes
May 28, 2023
talex5
approved these changes
May 28, 2023
There was a problem hiding this comment.
Thanks! Should we merge this now, or wait for ocaml/opam-repository#23832?
|
Merge away I say, can do a followup for the last pin-depends later. Need to wait a few days for feedback on the opam-repo one. |
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
May 29, 2023
A variant of this patch has been lingering externally since 2016 (ocaml/ocamlbuild#70), and Windows builds don't get very far without it any more, and it's blocking development of other upstream Windows ports (ocaml-multicore/eio#530). So barring strong objections, I'd like to pull this into opam-repository mainline. This package is only available on Windows. Source patch from https://github.com/fdopen/opam-repository-mingw/blob/opam2/packages/ocamlbuild/ocamlbuild.0.14.2/opam Reviewed by @dra27
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
May 29, 2023
A variant of this patch has been lingering externally since 2016 (ocaml/ocamlbuild#70), and Windows builds don't get very far without it any more, and it's blocking development of other upstream Windows ports (ocaml-multicore/eio#530). So barring strong objections, I'd like to pull this into opam-repository mainline. This package is only available on Windows. Source patch from https://github.com/fdopen/opam-repository-mingw/blob/opam2/packages/ocamlbuild/ocamlbuild.0.14.2/opam Reviewed by @dra27 and @patricoferris
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #529
This PR handles most of the external pins that the windows backend needed:
eio_windows. We should probably also bring thesendandrecvstubs along buteio_posixcould uses those, so perhaps a follow-up PR for that would be nice.eio_windowspackage. The patch either needs upstreaming to ocamlbuild or ocaml/opam-repository.