Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run Windows discover script on other platforms #511

Closed
wants to merge 1 commit into from

Conversation

talex5
Copy link
Collaborator

@talex5 talex5 commented May 8, 2023

Otherwise, dune build will try to run it and fail.

Otherwise, `dune build` will try to run it.
Copy link
Collaborator

@patricoferris patricoferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops should've tried the windows PR on non-windows, thanks!

@talex5
Copy link
Collaborator Author

talex5 commented May 10, 2023

This got merged, but GitHub seems to have forgotten to close it.

@talex5 talex5 closed this May 10, 2023
@talex5 talex5 deleted the fix-build branch May 10, 2023 09:34
talex5 added a commit to talex5/eio that referenced this pull request May 10, 2023
Don't run Windows discover script on other platforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants