Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf Breaking Change #131

Closed
RandomNameUser opened this issue Oct 6, 2022 · 0 comments · Fixed by #154
Closed

Protobuf Breaking Change #131

RandomNameUser opened this issue Oct 6, 2022 · 0 comments · Fixed by #154
Assignees
Labels

Comments

@RandomNameUser
Copy link

The current release does not work with the current version of protobuf, as they introduced breaking changes in 4.21.

Trying to use hindsight with a current protobuf version results in

18:01:41 chrome:get_site_characteristics:2134 ERROR - Exception parsing SiteDataProto ({'key': b'421aa90e079fa326b6494f812ad13e79', 'value': b'\x08\xf5\xaf\xf9\x99\x06', 'seq': 9, 'state': 'Live', 'file_type': 'Log', 'origin_file': WindowsPath('T:/scraper_chromedata/Default/Site Characteristics Database/000003.log'), 'offset': 581, 'was_compressed': False}): Descriptors cannot not be created directly.
If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0.
If you cannot immediately regenerate your protos, some other possible workarounds are:

  1. Downgrade the protobuf package to 3.20.x or lower.
  2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).
    More information: https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates

(and many more of these)

This should be fixed by just rerunning protoc and releasing a new version of hindsight.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants