-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map APO modifiers to PATO #927
Comments
My pairwise mappings:
|
hi @rays22 I think you have a typo on the APO:0000251 | premature | skos:exactMatch | PATO:0000498 | increased duration |
error on this line: APO:0000154 | petite-negative | skos:broadMatch | APO:0000153 | petite petite-negative != petite but i don't have a better suggestion! :( APO:0000154 | petite-negative | ?? | 0 | NONE |
correction for haploproficient: haploproficient != normal therefore should be: |
correction for premature: should be: |
last edit from me, protein/peptide accumulation should be: APO:0000149 | protein/peptide accumulation | ? | PATO:0002269 | accumulation |
Thank you @ValWood and @srengel for reviewing the table and the corrections.
|
Amazing @rays22 can you check this as a valid sssom file in https://github.com/monarch-initiative/monarch-mapping-commons ( |
I have a (possibly minor) comment about viability (but it does affect many annotations) In yeast biology "lethality" is used to refer to populations rather than cells This means that here because it refers to a population but here PomBase has many phenotypes for inviable cells at the single cell (organism) level, where population viability is decreased (because a high proportion cells are dead) but populations can be viable these need to be modelled as different phenotypes. "Inviable cell (or organism)" vs "inviable population" is quite an important distinction for microbial communities. It might not affect your work here, if SGD do not annotate phenotypes related to dead individual cells but I wanted to mention it because it is currently a conflation in the PATO ontology. Modelling death seems to be very tricky! |
we have inviable for just 'nothing grows'. we also have 'viability', and then either increased or decreased. with these two ways of recording 'death', we address what Val has described above. |
The following characteristics from SGD need to be mapped to PATO.
The text was updated successfully, but these errors were encountered: