Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle glob pub use imports #34

Closed
obi1kenobi opened this issue Aug 7, 2022 · 1 comment
Closed

Handle glob pub use imports #34

obi1kenobi opened this issue Aug 7, 2022 · 1 comment
Labels
A-lint Area: new or existing lint C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@obi1kenobi
Copy link
Owner

obi1kenobi commented Aug 7, 2022 •
edited
Loading

Right now, glob imports are ignored for purposes of calculating the "importable paths" of an item.

This is likely to cause false-negative issues where items aren't scanned but they should be. If moving from a non-glob to a glob pub use, this could also cause a false-positive "item was removed" issue. The circumstances to trigger a false-positive are exceedingly rare, but this should be fixed soon regardless.
@obi1kenobi obi1kenobi mentioned this issue Aug 7, 2022
Closed
@epage epage added A-lint Area: new or existing lint C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. labels Aug 9, 2022
@obi1kenobi obi1kenobi added the E-mentor Call for participation: Mentorship is available for this issue. label Aug 10, 2022
@obi1kenobi obi1kenobi mentioned this issue Jan 12, 2023
Closed
4 tasks
@obi1kenobi obi1kenobi mentioned this issue Jan 28, 2023
Merged
@obi1kenobi
Copy link
Owner Author

Fixed by #327.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: new or existing lint C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@epage @obi1kenobi