Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lint: pub trait method default implementation removed #293

Closed
2 tasks
SmolSir opened this issue Jan 17, 2023 · 1 comment
Closed
2 tasks

New lint: pub trait method default implementation removed #293

SmolSir opened this issue Jan 17, 2023 · 1 comment

Comments

@SmolSir
Copy link
Collaborator

SmolSir commented Jan 17, 2023

When the pub trait method's default implementation is removed, the method is no more provided and turns into a declared method. This forces the new version to implement the now-declared method in all of the impl blocks which were deriving that trait with its previously-provided method in the old version.

Required new version: Major

This requires some schema additions:

  • adding the edge from Trait to its Methods [linked PR]
  • enabling the has_body field for Method [linked PR]
@SmolSir SmolSir changed the title New lint: trait method body removed New lint: pub trait method default implementation removed Jan 17, 2023
@SmolSir SmolSir closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2023
@obi1kenobi
Copy link
Owner

Accidental duplicate of #294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants