Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lints related to function ABI changes #260

Open
1 of 3 tasks
Tracked by #241
staniewzki opened this issue Jan 5, 2023 · 0 comments
Open
1 of 3 tasks
Tracked by #241

Lints related to function ABI changes #260

staniewzki opened this issue Jan 5, 2023 · 0 comments

Comments

@staniewzki
Copy link
Collaborator

staniewzki commented Jan 5, 2023 •
edited by obi1kenobi
Loading

Original description:

  • things like extern "C" fn: https://docs.rs/rustdoc-types/latest/rustdoc_types/enum.Abi.html
  • new lints enabled by this:
    • ABI kind changed, e.g. extern "C" fn to extern "system" fn (or, if extern is removed, to the default extern "Rust" fn)
    • ABI unwind ability removed, e.g. extern "C-unwind" fn to extern "C" fn
    • is moving from extern "C" fn to extern "C-unwind" fn a breaking change?
      • technically, yes, but it's like adding #[non_exhaustive] when it was first introduced -- it's fairly new so let's not penalize early adopters
@staniewzki staniewzki mentioned this issue Jan 5, 2023
Open
11 tasks
@staniewzki staniewzki self-assigned this Jan 5, 2023
@obi1kenobi obi1kenobi changed the title expose ABI information on fn Lints related to function ABI Oct 12, 2023
@obi1kenobi obi1kenobi changed the title Lints related to function ABI Lints related to function ABI changes Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@staniewzki