Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle UTF8 filenames w/o UTF8 flag? #60

Open
obfusk opened this issue Nov 1, 2022 · 0 comments
Open

handle UTF8 filenames w/o UTF8 flag? #60

obfusk opened this issue Nov 1, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request maybe Unsure whether this will be worked on

Comments

@obfusk
Copy link
Owner

obfusk commented Nov 1, 2022

  • it looks like zipflinger never sets the flag and just assumes UTF8.
  • python needs the flag (or passing metadata_encoding in py >= 3.11) to decode properly (instead of using cp437).
  • v1 signature file names are most likely ASCII and unaffected.
  • copying is probably mostly unaffected:
    • as long as filename.decode("cp437").encode("cp437") == filename, which seems to be the case;
    • error messages containing file names might be affected though.
@obfusk obfusk added enhancement New feature or request maybe Unsure whether this will be worked on labels Nov 1, 2022
@obfusk obfusk self-assigned this Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maybe Unsure whether this will be worked on
Projects
None yet
Development

No branches or pull requests

1 participant