Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor sprite renderer #64

Merged
merged 63 commits into from
Mar 24, 2021
Merged

Refactor sprite renderer #64

merged 63 commits into from
Mar 24, 2021

Conversation

singlecoder
Copy link
Member

@singlecoder singlecoder commented Feb 19, 2021 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Refactor sprite renderer.

What is the current behavior? (You can also link to an open issue here)

#32

What is the new behavior (if this is a feature change)?

  • Add some new api.
  • Optimize the underlying rendering pipeline.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

@singlecoder singlecoder added this to the 0.3 milestone Feb 19, 2021
@singlecoder singlecoder changed the title Dev/0.3 Dev/0.3: Refactor sprite renderer Feb 19, 2021
@singlecoder singlecoder changed the title Dev/0.3: Refactor sprite renderer Refactor sprite renderer Feb 19, 2021
@GuoLei1990 GuoLei1990 linked an issue Feb 19, 2021 that may be closed by this pull request
SpriteRenderer Refactor #32
Closed
5 tasks
GuoLei1990
GuoLei1990 requested changes Mar 1, 2021
View reviewed changes
packages/core/src/2d/sprite/Sprite.ts Outdated Show resolved Hide resolved
packages/core/src/2d/sprite/Sprite.ts Outdated Show resolved Hide resolved
packages/core/src/2d/sprite/Sprite.ts Outdated Show resolved Hide resolved
packages/core/src/2d/sprite/Sprite.ts Show resolved Hide resolved
packages/core/src/2d/sprite/SpriteRenderer.ts Outdated Show resolved Hide resolved
@GuoLei1990 GuoLei1990 marked this pull request as draft March 2, 2021 06:41
GuoLei1990
GuoLei1990 reviewed Mar 23, 2021
View reviewed changes
packages/core/src/2d/sprite/Sprite.ts Outdated Show resolved Hide resolved
packages/core/src/2d/sprite/Sprite.ts Outdated Show resolved Hide resolved
GuoLei1990
GuoLei1990 approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@GuoLei1990 GuoLei1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 marked this pull request as ready for review March 24, 2021 10:10
@GuoLei1990 GuoLei1990 merged commit e19968d into galacean:dev/0.3 Mar 24, 2021
@GuoLei1990 GuoLei1990 added the 2D label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoLei1990 GuoLei1990 GuoLei1990 approved these changes

@eyworldwide eyworldwide Awaiting requested review from eyworldwide

@gz65555 gz65555 Awaiting requested review from gz65555

@zhuxudong zhuxudong Awaiting requested review from zhuxudong

Assignees

@GuoLei1990 GuoLei1990

Labels
None yet
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.

SpriteRenderer Refactor
2 participants
@singlecoder @GuoLei1990