Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: texture upload warnning #183

Merged
merged 3 commits into from
Apr 12, 2021
Merged

fix: texture upload warnning #183

merged 3 commits into from
Apr 12, 2021

Conversation

GuoLei1990
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@GuoLei1990 GuoLei1990 added the bug Something isn't working label Apr 12, 2021
@GuoLei1990 GuoLei1990 self-assigned this Apr 12, 2021
zhuxudong
zhuxudong approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@zhuxudong zhuxudong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 merged commit 4a9c0c9 into galacean:main Apr 12, 2021
luzhuang pushed a commit to luzhuang/engine that referenced this pull request Sep 6, 2022
@GuoLei1990
fix: texture upload warnning (galacean#183)
da75b02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuxudong zhuxudong zhuxudong approved these changes

@gz65555 gz65555 Awaiting requested review from gz65555

@cptbtptpbcptdtptp cptbtptpbcptdtptp Awaiting requested review from cptbtptpbcptdtptp

@czizzy czizzy Awaiting requested review from czizzy

@eyworldwide eyworldwide Awaiting requested review from eyworldwide

@johanzhu johanzhu Awaiting requested review from johanzhu

@luzhuang luzhuang Awaiting requested review from luzhuang

@singlecoder singlecoder Awaiting requested review from singlecoder

Assignees

@GuoLei1990 GuoLei1990

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuoLei1990 @zhuxudong