This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-51] add more datatype fallback logic in columnar operators #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rui-mo
force-pushed
the
wip_datatype
branch
3 times, most recently
from
5260c75
to
cd1d11e
Compare
|
@zhouyuan verified TPC-DS/H on both decimal and double dataset. |
|
note: along with this #7 all operators except scan and shuffle will fallabck to row operators on decimal datatype |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr added more datatype fallback logic in columnar operators.
With this pr, the official TPC-DS works on double dataset.
#51
How was this patch tested?
locally tested