Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

[NSE-173] fix incorrect result of q69 #174

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

rui-mo
Copy link
Collaborator

@rui-mo rui-mo commented Mar 19, 2021

What changes were proposed in this pull request?

This pr fixes the incorrect result of q69, occurring due to wrong offset and size when copying bitmap.
fixed #173.
#153

How was this patch tested?

q69 was verified, other queries are under testing

@github-actions
Copy link

#173

@rui-mo rui-mo force-pushed the wip_fix_inplace branch 2 times, most recently from e93b833 to dcbfec0 Compare March 19, 2021 04:49
@github-actions
Copy link


@github-actions
Copy link


@rui-mo rui-mo force-pushed the wip_fix_inplace branch 2 times, most recently from 55e1408 to 6818181 Compare March 19, 2021 09:04
@github-actions
Copy link


@github-actions
Copy link


@github-actions
Copy link


arrow::Status SliceBitmap(const std::shared_ptr<arrow::Buffer>& buffer,
std::shared_ptr<arrow::Buffer>* out) {
Range range(size * offset_, size * length_);
Range range(offset_, length_);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a big change, does this mean only q69 use sortinplace?

@zhouyuan
Copy link
Collaborator

verified locally, q69 is correct now

@zhouyuan zhouyuan merged commit b3f5d24 into oap-project:master Mar 22, 2021
@rui-mo
Copy link
Collaborator Author

rui-mo commented Mar 22, 2021

verified TPC-DS on both partition/non-partition table

zhouyuan added a commit that referenced this pull request Mar 29, 2021
* [NSE-130] support decimal round and abs (#166)

* support decimal round and abs

* remove duplicate cast in multiply/divide

* [NSE-161] adding format check (#165)

* adding format check

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* formating code

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* adding google format

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* reformat with new style

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* lower clang version to 10

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* adding script to format code

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* [NSE-170]improve sort shuffle code (#171)

* improve sort shuffle code

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* fix format

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* pass by ref in builder

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* fix string/decimal builder

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* [NSE-62]Fixing issue0062 for package arrow dependencies in jar with refresh2 (#172)

* Add arrow build and dependency support

* Add compress.sh default value

* Fix bug for parameter's default value

* Add CACHE PATH

* fix copy bitmap in InplaceSort (#174)

* [NSE-153] fix window results (#175)

* fix window sort memory

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* remove unused code

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* fix windown w/o avg

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* fix format

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* fix decimal sort

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* Fix issue 179 for arrow include directory (#181)

* Fix issue0191 for .so file copy to tmp. (#192)

* Following NSE-153, optimize fallback conditions for columnar window (#189)

* Fix q14a/b segfault (#193)

Signed-off-by: Chendi Xue <chendi.xue@intel.com>

* [NSE-194]Turn on several Arrow parameters (#195)

* Turn on several Arrow parameters

* Change SIMD Level Setting

* Hashmap build opt for semi/anti/exists join (#197)

Signed-off-by: Chendi Xue <chendi.xue@intel.com>

* [NSE-198] support the month() and dayofmonth() functions with DateType (#199)

* [NSE-206] fix doc link, update limitations (#205)

* fix doc link

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* update arrow data source

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* adding limitations

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* mention limits

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* [NSE-170] using unsafe appender (#203)

This patch adds an unsafe appender which will reserve space before builder array.
The boolean builder is not touched as only malloc small sized memory
The string builder are not touched as it's diffcult to pre-allocate the space

* using unsafe appender

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* fix format

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

* update arrow branch

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>

Co-authored-by: Rui Mo <rui.mo@intel.com>
Co-authored-by: Wei-Ting Chen <weiting.chen@intel.com>
Co-authored-by: Hongze Zhang <hongze.zhang@intel.com>
Co-authored-by: Chendi.Xue <chendi.xue@intel.com>
Co-authored-by: JiaKe <ke.a.jia@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix the incorrect result of q69
2 participants