This repository has been archived by the owner on Sep 18, 2023. It is now read-only.
[NSE-145] Support decimal in columnar window #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyuan
approved these changes
Mar 10, 2021
|
|
zhouyuan
reviewed
Mar 10, 2021
| } | ||
|
|
||
| TEST(TestArrowComputeWindow, DecimalAvgTest) { | ||
| return; // fixme decimal avg not supported? |
There was a problem hiding this comment.
spark will cast decimal data to double in hash agg, i think we could follow this in window
zhouyuan
reviewed
Mar 10, 2021
| StructField("cs_net_paid_inc_ship", DoubleType), | ||
| StructField("cs_net_paid_inc_ship_tax", DoubleType), | ||
| StructField("cs_net_profit", DoubleType) | ||
| StructField("cs_wholesale_cost", DecimalType(7, 2)), |
There was a problem hiding this comment.
thanks for changing this to decimal!
|
|
|
|
|
|
|
|
This was referenced Mar 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#145