-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a branch/release for pre plugin-sdk release #196
Comments
@rgolangh , IMO, a new branch is good choice for this. While I still have two more questions:
Thanks. |
Do you mean for cherry picking?
OKD 4.4 installer uses that and it only changes in 4.5. For me it should be there as long as OKD .4.4 will use it.
|
Rebase is clean and the diff shows only changes to the import statements: |
Also left a comment on the README to note about the terraform version |
@imjoey Before closing this, do you have any way to automate cherry picks? github actions? travis? |
closing for now. CI is a different topic we need to handle. |
This issue is release oriented.
Motivation
OKD installer [1] is vendoring the provider, along with few others and all
of them, till certain point in time[2] still don't use the terraform plugin-sdk.
Now I'm in a point where I need to fix something in the provider, and to revendor
it, but I'm blocked because our provider already migrated to the plugin-sdk [3]
Hence I need a way to consume and maintain a version which is still pre plugin sdk.
The way to do it is most probably to branch from [3] and cherry pick fixes on top.
@imjoey Since I didn't create any release on this repo yet I want hear your thoughts about how to address that.
[1] https://github.com/openshift/installer
[2] openshift/installer#2745
[3] #188
The text was updated successfully, but these errors were encountered: