Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website Search Returns No Results for CVAR prefixes #1924

Closed
AMZN-Gene opened this issue Aug 22, 2022 · 6 comments · Fixed by #2238
Closed

Website Search Returns No Results for CVAR prefixes #1924

AMZN-Gene opened this issue Aug 22, 2022 · 6 comments · Fixed by #2238
Assignees
Labels
kind/website Categorizes an issue or PR as related to the website itself. status/discuss Issues opened for discussions and feedbacks. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@AMZN-Gene
Copy link
Contributor

AMZN-Gene commented Aug 22, 2022

Describe the bug

Searching for editorsv or editorsv_ cvar prefix returns no results

Reproduction steps

Open o3de.org
In the search bar search for "editorsv"
Notice there are no results
image

Expected behavior

The page with all of editorsv cvars should appear
https://www.o3de.org/docs/user-guide/networking/settings/

@AMZN-Gene AMZN-Gene added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 22, 2022
@FiniteStateGit FiniteStateGit added kind/website Categorizes an issue or PR as related to the website itself. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 24, 2022
@FiniteStateGit
Copy link
Contributor

As a quick fix we could add content to the page that calls out the prefixes used for cvars. Alternatively, larger changes to our current search implementation or new search solutions could address this and similar problems.

@ghost
Copy link

ghost commented Sep 19, 2022

@sptramer @FiniteStateGit

Applied the fix in the repo. It now searches properly. The document indentations were wrong on the tables and some wrong displaced areas.

image

@willihay willihay changed the title Website Search Returns No Results Website Search Returns No Results for CVAR prefixes Dec 7, 2022
@willihay
Copy link
Contributor

willihay commented Dec 7, 2022

Proposed fix: Use the prefix by itself in the introduction to the tables that we have for each prefix.

For example, change: "The following console variables control client behavior."

To: "The cl CVARs control client behavior."

@willihay willihay self-assigned this Dec 7, 2022
@AMZN-Gene
Copy link
Contributor Author

@NiklasHenricson is your fix on O3DE.org now? The pr said it was checked into “main” but the search still returns empty today.

@AMZN-Gene
Copy link
Contributor Author

Proposed fix: Use the prefix by itself in the introduction to the tables that we have for each prefix.

For example, change: "The following console variables control client behavior."

To: "The cl CVARs control client behavior."

+1.

@AMZN-Gene
Copy link
Contributor Author

Still an issue in both development and 21.10 versions of o3de.org
image

@FiniteStateGit FiniteStateGit added the status/discuss Issues opened for discussions and feedbacks. label Feb 7, 2023
@willihay willihay linked a pull request Feb 8, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/website Categorizes an issue or PR as related to the website itself. status/discuss Issues opened for discussions and feedbacks. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants