SVG support

[Rolv-Apneseth]

Summary 💡

When running onefetch --image path/to/file.svg, I get the following error:

Error: Could not load the specified image

Caused by:
    The file extension `."svg"` was not recognized as an image format

While I don't know about the other image back ends, I do know that kitty does support svg files (as confirmed here), so would it be possible to integrate support for these files for onefetch? I can work on this, just need to know if it's possible or something you would even be interested in.

Motivation 🔦

I would like to be able to display an svg file I have for a specific git repo.

[o2sh]

Thanks for reporting this @Rolv-Apneseth

Seems to be an issue with the image crate, which only supports raster formats: image-rs/image#524 (comment)

The error message comes from this line:

onefetch/src/ui/printer.rs

Line 48 in e401c3c

Some(p) => Some(image::open(p).context("Could not load the specified image")?),

[Rolv-Apneseth]

Hmm I see, maybe it's a bit much for this project or what do you think? Very niche anyways I suppose.

[spenserblack]

Yeah, quickly going through the image-rs docs and source code, I don't think it's possible for a 3rd-party to register a new format. At least not for image::open (less abstracted usage might still be possible). Though I'd be happy if it turns out I missed something 😆 But this means it won't be easy to support SVGs.

Just speaking generally about image decoding, I think at least partial support for SVGs could be achieved by requiring the user to specify dimensions. So I wouldn't be surprised if a crate existed that implemented the image-rs traits for a type that represents an SVG image.

(We could at least support SVGs as a detected language 😜)

[o2sh]

(We could at least support SVGs as a detected language 😜)

You're right, somehow it was missing from the list of languages in #490 😅

[o2sh]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.