Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count hidden files and directories #465

Merged
merged 6 commits into from
Jul 10, 2021
Merged

Count hidden files and directories #465

merged 6 commits into from
Jul 10, 2021

Conversation

0x20F
Copy link
Contributor

@0x20F 0x20F commented Jul 10, 2021

Closes #464

@o2sh
Copy link
Owner

o2sh commented Jul 10, 2021

Thanks for your PR @0x20F
IMO, it would be preferable to follow tokei's example and have a CLI flag --hidden that defaults to false.

@0x20F
Copy link
Contributor Author

0x20F commented Jul 10, 2021 •
edited
Loading

I agree @o2sh , it's a lot nicer to allow users to choose.
I'm not sure if I did it the best way it could be done, feedback is welcome 😅

@o2sh
Copy link
Owner

o2sh commented Jul 10, 2021

LGTM 🎉

Thanks a lot for your contribution @0x20F

@o2sh o2sh merged commit 8a9cb2d into o2sh:main Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discover hidden files and directories
2 participants
@0x20F @o2sh